Bug 89 – Add support to generic Stream classes instead of hardcoding QDataStream and QTextStream

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 89 - Add support to generic Stream classes instead of hardcoding QDataStream and QTextStream

Summary:

Add support to generic Stream classes instead of hardcoding QDataStream and Q...

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	ApiExtractor
Version:	HEAD
Platform:	All All

Importance:	P5 enhancement
Assigned To:	Lauro Moura

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-31 16:28 EET by Lauro Moura
Modified:	2010-03-24 16:45 EET (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lauro Moura 2009-10-31 16:28:41 EET

Currently the function AbstractMetaBuilder::traverseStreamOperators contains
hardcoded stuff for QDataStream and QTextStream. It would be good to have this
available for any stream-like class.

I did some experiments with it by adding a attribute stream="yes" to
<object-type> and <value-type> tags and querying AbstractMetaClass::isStream()
instead of using the names QDataStream and QTextStream.

Branch on apiextractor - the fix
http://qt.gitorious.org/~lauromoura/pyside/lauromoura-apiextractor/commits/stream

Branch on shiboken - with updated example for externally defined <</>>
operators)
http://qt.gitorious.org/~lauromoura/pyside/lauromoura-shiboken/commits/stream

Branch on pyside - adds stream="true" to QDataStream/QTextStream definitions
http://qt.gitorious.org/~lauromoura/pyside/lauromoura-pyside/commits/stream

With the shiboken and apiextractor commits I managed to reproduce de
PySide-shiboken error in the libsample.

Should I go ahead and request merge?

Comment 1 Lauro Moura 2009-11-03 21:35:38 EET

So, more updates:

apiextractor:stream - Now modifying the number of arguments of
"streamed/internalized" functions
boostpythongenerator:stream - Updated for this modification
shiboken:stream - Updated test and rebasing on mainline.

Comment 2 Lauro Moura 2009-11-11 18:01:29 EET

Fixed with the stream="yes" attribute in value-type/object-type tags.

Already merget into mainline.