Bug 828 – Multiple QDirModel/QFileSystemModel bugs

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 828 - Multiple QDirModel/QFileSystemModel bugs

Summary:

Multiple QDirModel/QFileSystemModel bugs

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Documentation
Version:	HEAD
Platform:	All All

Importance:	P3 normal
Assigned To:	renato filho

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-04-14 11:51 EEST by anatoly techtonik
Modified:	2011-05-30 20:52 EEST (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description anatoly techtonik 2011-04-14 11:51:08 EEST

Starting
http://www.pyside.org/docs/pyside/PySide/QtGui/QTreeView.html#detailed-description,
example with QDirModel() contains 'splitter' argument that is not described.

Then at QDirModel page at
http://www.pyside.org/docs/pyside/PySide/QtGui/QDirModel.html#detailed-description
it is recommended to use QFileSystemModel instead.

Looking at QFileSystemModel page
http://www.pyside.org/docs/pyside/PySide/QtGui/QFileSystemModel.html#PySide.QtGui.QFileSystemModel
docs doesn't describe immediate difference from QDirModel, and just
substituting this class doesn't work (it described further in caching section,
but still). Maybe the primary confusion comes from the fact that example
contains QDirModel() and `splitter` instead of QFileSystemModel.

Comment 1 Hugo Parente Lima 2011-04-15 17:20:21 EEST

QDirModel was tagged as obsolete by Qt.
QDileSystemModel like the docs says, "is a more performant alternative".

Prioritizing as P3, the example inside QFileSystemModel is definitely wrong.

Comment 2 renato filho 2011-05-05 21:45:34 EEST

code example updated to use QFileSystemModel.

fixed on pyside commit:

commit 964eb13adf4760a20c07e629f62c7d6f14fac132
Author: Renato Filho <renato.filho@openbossa.org>
Date:   Thu May 5 14:23:06 2011 -0300

Comment 3 renato filho 2011-05-26 17:04:04 EEST

PySide release 1.0.3

Comment 4 anatoly techtonik 2011-05-28 11:16:20 EEST

Thanks for pinging me. Weird 'splitter' argument is still there.

Comment 5 Hugo Parente Lima 2011-05-30 17:42:21 EEST

(In reply to comment #4)
> Thanks for pinging me. Weird 'splitter' argument is still there.

The code snippets are just snippets, they are part of something just to show
how to use the class, the C++ version also has the splitter argument that is
supposed to be the parent widget. OTOH I agree that in this case the splitter
argument doesn't help the understanding of the example at all despite of it
being trivial,  anyway I'm going to remove it.

Comment 6 Hugo Parente Lima 2011-05-30 20:52:59 EEST

splitter arg removed in commit:

pyside/30444ccab72906fe3f57ca63c770127d40f191ea