Bug 418 – tag parent does not work in constructor modify

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 418 - tag parent does not work in constructor modify

Summary:

tag parent does not work in constructor modify

Status:	CLOSED INVALID

Product:	PySide
Classification:	Unclassified
Component:	PySide
Version:	HEAD
Platform:	All All

Importance:	P3 normal
Assigned To:	renato filho

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-10-15 18:24 EEST by renato filho
Modified:	2010-11-25 17:53 EET (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description renato filho 2010-10-15 18:24:42 EEST

the tag used to specify the parent policy does not work when used in
constructor modification.


In this case I changed the the xml to works for now, Fix this when bug was
fixed.

<value-type name="QTreeWidgetItemIterator" >
    <modify-function signature="QTreeWidgetItemIterator(QTreeWidget *, ...)"> 
        <inject-code class="target" position="end">
            Shiboken::setParent(%PYARG_1, (PyObject*)sbkSelf);
        </inject-code>
    </modify-function>


The correct is:
<value-type name="QTreeWidgetItemIterator" >
    <modify-function signature="QTreeWidgetItemIterator(QTreeWidget *, ...)"> 
       <modify-argument index="return">
          <parent index="1" action="add"/>
       </modify-function>
    </modify-function>

Comment 1 Hugo Parente Lima 2010-10-20 12:15:16 EEST

The correct is;

<value-type name="QTreeWidgetItemIterator" >
    <modify-function signature="QTreeWidgetItemIterator(QTreeWidget *, ...)"> 
       <modify-argument index="this">
          <parent index="1" action="add"/>
       </modify-function>
    </modify-function>

and was pushed to the mainline in commit:

pyside/5100b62bdca70d48d5d441cc33ca941053ae1551

Comment 2 Hugo Parente Lima 2010-11-25 17:53:40 EET

Released on version 1.0.0~beta1