Bug 366 – Generating wrong code for overloads with 0 or 1 arguments and ownership transfer

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 366 - Generating wrong code for overloads with 0 or 1 arguments and ownership transfer

Summary:

Generating wrong code for overloads with 0 or 1 arguments and ownership transfer

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	All All

Importance:	P3 major
Assigned To:	Marcelo Lira

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-09-17 20:49 EEST by Lauro Moura
Modified:	2010-10-13 13:48 EEST (History)
CC List:	8 users (show)

See Also:

Attachments
Proposed fix plus test. (2.38 KB, patch) 2010-09-17 20:49 EEST, Lauro Moura	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lauro Moura 2010-09-17 20:49:04 EEST

Created attachment 88 [details]
Proposed fix plus test.

The code generated uses the argument name "arg" for the first argument in
ownership transfers in all overloads with 1 or less arguments, when it should
be used only when exactly 1 argument is found.

Example: QAudioInput.start()/start(QIODevice*). Instead of using pyargs[1], the
code generated uses 'arg', thus breaking the build.

Fix and test case attached.

Marking as major as it breaks the build of QtMultimedia.

Comment 1 renato filho 2010-09-20 14:15:51 EEST

patch applied on shiboken commit:

commit 2b8f4f3d19256f306be1c354eb62a7b367926d43
Author: Lauro Neto <lauro.neto@openbossa.org>
Date:   Fri Sep 17 20:13:58 2010 -0300

Comment 2 renato filho 2010-10-13 13:48:47 EEST

released on PySide 0.4.2