Bug 287 – Replace renamed functions with overloads: QTextFormat, QRubberBand, QSpinBox, QTextBrowser, QDoubleSpinBox, QPainter, QStackedLayout, QTextList

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 287 - Replace renamed functions with overloads: QTextFormat, QRubberBand, QSpinBox, QTextBrowser, QDoubleSpinBox, QPainter, QStackedLayout, QTextList

Summary:

Replace renamed functions with overloads: QTextFormat, QRubberBand, QSpinBox,...

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	QtGui
Version:	0.4.0
Platform:	All All

Importance:	P5 normal
Assigned To:	renato filho

URL:	http://lists.openbossa.org/pipermail/...

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-08-06 19:58 EEST by Dan Halbert
Modified:	2010-09-10 19:21 EEST (History)
CC List:	7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dan Halbert 2010-08-06 19:58:32 EEST

There are a number of renamed functions in PySide that perhaps could be done
with overloads instead. PyQt does use overloads in these cases.

From QtGui/typesystem_gui_common.xml:

<value-type name="QTextFormat" >
    <modify-function signature="setProperty(int,QVector&lt;QTextLength&gt;)"
rename="setLengthVectorProperty"/>

<object-type name="QRubberBand">
    <modify-function signature="move(int,int)" rename="moveRubberBand"/>
    <modify-function signature="move(const QPoint &amp;)"
rename="moveRubberBand"/>
    <modify-function signature="resize(int,int)" rename="resizeRubberBand"/>
    <modify-function signature="resize(const QSize &amp;)"
rename="resizeRubberBand"/>
    <modify-function signature="setGeometry(int,int,int,int)"
rename="setRubberBandGeometry"/>
    <modify-function signature="setGeometry(const QRect &amp;)"
rename="setRubberBandGeometry"/>

<object-type name="QSpinBox">
    <modify-function signature="valueChanged(const QString &amp;)">
      <rename to="valueStringChanged"/>

<object-type name="QTextBrowser">
    <modify-function signature="highlighted(const QString &amp;)">
      <rename to="highlightedString"/>

<object-type name="QDoubleSpinBox">
    <modify-function signature="valueChanged(const QString &amp;)">
      <rename to="valueStringChanged"/>

<object-type name="QPainter">
    <modify-function signature="drawLines(const QVector&lt;QPoint&gt; &amp;)">
      <rename to="drawLinesFromPoints"/>
    </modify-function>
    <modify-function signature="drawLines(const QVector&lt;QPointF&gt; &amp;)">
      <rename to="drawLinesFromPointsF"/>
    </modify-function>
    <modify-function signature="drawLines(const QVector&lt;QLineF&gt; &amp;)">
      <rename to="drawLinesF"/>
    </modify-function>
    <modify-function signature="drawRects(const QVector&lt;QRectF&gt; &amp;)">
      <rename to="drawRectsF"/>

Comment 1 Dan Halbert 2010-08-06 20:03:50 EEST

Also maybe:

<object-type name="QStackedLayout">
<modify-function signature="addWidget(QWidget *)">
  <rename to="addStackedWidget" /> 
  <inject-code class="target" position="beginning">addLayoutOwnership(%CPPSELF,
%1);</inject-code>

<object-type name="QTextList">
  <modify-function signature="format()const" rename="textListFormat" />

Comment 2 Dan Halbert 2010-08-06 20:05:25 EEST

(In reply to comment #1)
I neglected to say the QStackedList and QTextFormat ones are not overloads, but
the need to rename is not clear to me. PyQt does not rename them.

Comment 3 renato filho 2010-08-12 14:57:47 EEST

Fixed on commit:

commit 533cdcd07b61ffe7d578f0c54b923a1fdbff2ced
Author: Renato Filho <renato.filho@openbossa.org>
Date:   Thu Aug 12 14:56:25 2010 -0300