Bug 148 – Includes a copy of sparsehash

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 148 - Includes a copy of sparsehash

Summary:

Includes a copy of sparsehash

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	All All

Importance:	P5 major
Assigned To:	Marcelo Lira

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-02-12 09:18 EET by Didier Raboud
Modified:	2010-06-21 10:09 EEST (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Didier Raboud 2010-02-12 09:18:51 EET

Hi, 

Shiboken's git includes a copy of sparsehash in its ext/ directory. I want to
avoid repacking (stripping these bits out) and patching (making shiboken build
with sparsehash "upstream".

As distributors (e.g. Debian), we really dislike having embedded copies of
code: it implies much work when issues arise in the embedded code: patching
must happen everywhere.

Furthermore, sparsehash is compiled for many distributions (Arch, FreeBSD,
Fink, MacPorts, Debian and Ubuntu at least), so you can "just" use the
developement packages in your workflow.

Thanks in advance, 

OdyX

Comment 1 Hugo Parente Lima 2010-02-12 13:39:54 EET

We use just a subset of sparsehash and sparsehash is a header-only template
library. So it's much more easier to include our own copy of this *single* file
on our project than expect to find this package on distros. Besides not all
distros have a package for sparsehash, so not including this *single* file
means force some packagers to create an adictional package just because we did
not include a single header on our project.

IMO, patching libshiboken on debian to not use our copy of sparsehash will just
add useless complexity to the buildsystem, package scripts, etc... for
absolutly no gain at all.

P.S.: There isn't a package for sparsehash on ArchLinux as you said, at least
not in core, extra, community and testing repositories, problably just on AUR.

Comment 2 Didier Raboud 2010-06-21 08:49:08 EEST

Yay. Thanks for fixing this ! :->

http://qt.gitorious.org/pyside/shiboken/commit/c20a1028599734352c7491abf539d607a9ff748d
http://qt.gitorious.org/pyside/shiboken/commit/d2175970450b01829c510d745c227e8b68e1f3e6

This will reduce Debian's diff, which is great !