PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 117 - Shiboken doesn't compiles with Python2.5
: Shiboken doesn't compiles with Python2.5
Status: CLOSED FIXED
Product: PySide
Classification: Unclassified
Component: Shiboken
: HEAD
: All All
: P5 normal
Assigned To: Anderson Lizardo
:
:
:
  Show dependency treegraph
 
Reported: 2010-01-11 15:29 EET by Michele Petrazzo
Modified: 2010-02-04 11:43 EET (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michele Petrazzo 2010-01-11 15:29:54 EET
Hi. Just tried to compile the last git and:

[ 42%] Building CXX object
tests/samplebinding/CMakeFiles/sample.dir/sample/abstractmodifications_wrapper.cpp.o
/home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp:
In function ‘void init_abstractmodifications(PyObject*)’:
/home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp:200:
error: ‘struct Shiboken::SbkBaseWrapperType’ has no member named ‘ob_refcnt’
make[2]: ***
[tests/samplebinding/CMakeFiles/sample.dir/sample/abstractmodifications_wrapper.cpp.o]
Error 1
make[1]: *** [tests/samplebinding/CMakeFiles/sample.dir/all] Error 2
Comment 1 Luciano Wolf 2010-01-11 17:15:11 EET
I've just tried today's version from git repository and everything
(apiextractor / generatorrunner / shiboken[commit
#cdb91dc7438da10abe071eb852dc0db00ad90695] / pyside-shiboken) was ok. Could you
check again?
Comment 2 Michele Petrazzo 2010-01-12 05:59:36 EET
michele:/home/devel/pyside/shiboken$ git pull && git log | head -n1
Already up-to-date.
commit cdb91dc7438da10abe071eb852dc0db00ad90695
michele:/home/devel/pyside/shiboken$ make
[  5%] Built target shiboken_generator
[  6%] Built target shiboken
[ 10%] Built target libshiboken
[ 39%] Built target libsample
[ 40%] Built target libother
[ 41%] Building CXX object
tests/samplebinding/CMakeFiles/sample.dir/sample/abstractmodifications_wrapper.cpp.o
/home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp:
In function ‘void init_abstractmodifications(PyObject*)’:
/home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp:200:
error: ‘struct Shiboken::SbkBaseWrapperType’ has no member named ‘ob_refcnt’
make[2]: ***
[tests/samplebinding/CMakeFiles/sample.dir/sample/abstractmodifications_wrapper.cpp.o]
Error 1
make[1]: *** [tests/samplebinding/CMakeFiles/sample.dir/all] Error 2
make: *** [all] Error 2
michele:/home/devel/pyside/shiboken$

Could I try to remove the sample dir?
Comment 3 Anderson Lizardo 2010-01-12 09:42:28 EET
Some simple questions which might help debugging:

* What is your Python version?
* Can you paste the contents of
/home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp
somewhere ? (e.g. http://pastebin.com/).

Thanks.
Comment 4 Michele Petrazzo 2010-01-12 13:33:42 EET
(In reply to comment #3)
> Some simple questions which might help debugging:
> 
> * What is your Python version?

michele:/home/devel/pyside/shiboken$ python --version
Python 2.5.2

> * Can you paste the contents of
> /home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp
> somewhere ? (e.g. http://pastebin.com/).

http://pastebin.com/f5e449ddb
Comment 5 Hugo Parente Lima 2010-01-12 13:51:45 EET
Maybe this is the problem, Shiboken wasn't tested with Python 2.5.
Comment 6 Michele Petrazzo 2010-01-12 14:52:49 EET
(In reply to comment #5)
> Maybe this is the problem, Shiboken wasn't tested with Python 2.5.

I'm trying to install py2.6 and I'll re-try the Shiboken's compilation with the
2.6. I'll let you know.

P.s. I'm on debian where stable, testing and unstable are *all* with 2.5 like
now, so I think that pyside should be compiled with that py version.
Comment 7 Michele Petrazzo 2010-01-12 15:02:55 EET
(In reply to comment #6)
> (In reply to comment #5)
> > Maybe this is the problem, Shiboken wasn't tested with Python 2.5.
> 
> I'm trying to install py2.6 and I'll re-try the Shiboken's compilation with the
> 2.6. I'll let you know.
> 


Do you know how to specify to cmake / make how to use python2.6 that aren't the
default python on the system / aren't on the default path (I have it on
/home/devel/python2.6)

Thanks,
Michele
Comment 8 Matti Airas 2010-01-14 08:43:11 EET
(In reply to comment #3)

> * Can you paste the contents of
> /home/devel/pyside/shiboken/tests/samplebinding/sample/abstractmodifications_wrapper.cpp
> somewhere ? (e.g. http://pastebin.com/).

Not related to the problem itself: please attach any related material to the
bug itself instead of requesting to use external services. That'll ensure that
the information stays accessible and in one place.

Thanks. :-)
Comment 9 Anderson Lizardo 2010-02-03 17:38:12 EET
Fixed on master:

commit b7da6f1362e7acffcd64ca7c09cd5c522395ae05
Author: Anderson Lizardo <anderson.lizardo@openbossa.org>
Date:   Wed Feb 3 09:53:45 2010 -0400

    Fix build with Python 2.5 when using Py_INCREF()

    On Python 2.5, Py_INCREF() does not cast the passed pointer to PyObject*
(like
    in Python 2.6 and newer versions). To make sure the generated code works on
    Python 2.5, use reinterpret_cast<PyObject*>().
Comment 10 Michele Petrazzo 2010-02-04 06:07:20 EET
(In reply to comment #9)
> Fixed on master:
> 
> commit b7da6f1362e7acffcd64ca7c09cd5c522395ae05
> Author: Anderson Lizardo <anderson.lizardo@openbossa.org>
> Date:   Wed Feb 3 09:53:45 2010 -0400

Yes!
Here it works without problem.
For me this bug is done!

Thanks,
Michele