Bug 1066 – Explicitly describe return value of QFileDialog.getOpenFileName(s)

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 1066 - Explicitly describe return value of QFileDialog.getOpenFileName(s)

Summary:

Explicitly describe return value of QFileDialog.getOpenFileName(s)

Status:	NEW

Product:	PySide
Classification:	Unclassified
Component:	Documentation
Version:	HEAD
Platform:	PC Other

Importance:	P4 enhancement
Assigned To:	Hugo Parente Lima

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-18 14:06 EET by Vladimir Rutsky
Modified:	2012-03-08 16:57 EET (History)
CC List:	9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vladimir Rutsky 2011-11-18 14:06:17 EET

When no file selected with QFileDialog.getOpenFileName() it returns (u'', u''),
QFileDialog.getOpenFileName() returns ([], u''), which is not obvious and not
Pythonic (Pythonic way whould be return None in case when nothing selected,
IMO).

This behavior should be explicitly described.

Comment 1 Hugo Parente Lima 2011-11-23 15:25:54 EET

Such behavior change would require a PSEP, besides discussions on mailing list
of what would be considered pythonic in this case, so marking as wontfix, if
this behavior change gets approved we can reopen this bug or file an
enhancement request.

Comment 2 Vladimir Rutsky 2011-11-23 20:31:12 EET

Hugo, in this bug report I'm not requesting change of return type, I'm asking
to _document_ return value from QFileDialog.getOpenFileName() _when no file
selected_. Please reconsider your resolution.

Comment 3 Hugo Parente Lima 2011-11-29 20:46:46 EET

Ah, ok, sorry for the not understand at first time.

Comment 4 Matti Airas 2012-03-08 16:57:22 EET

PySide is now a Qt-addon and uses Qt Project's JIRA tool for tracking bugs.
Please verify that the bug is still valid and re-submit it in the address
below:

https://bugreports.qt-project.org/

Sorry for the inconvenience!