Bug 1058 – Strange code in PySide/QtUiTools/glue/plugins.h

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 1058 - Strange code in PySide/QtUiTools/glue/plugins.h

Summary:

Strange code in PySide/QtUiTools/glue/plugins.h

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	QtUiTools
Version:	HEAD
Platform:	PC All

Importance:	P2 normal
Assigned To:	Paulo Alcantara

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-15 18:37 EET by Vladimir Rutsky
Modified:	2011-11-29 21:28 EET (History)
CC List:	10 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vladimir Rutsky 2011-11-15 18:37:16 EET

There is quite strange loop in PySide/QtUiTools/glue/plugins.h in PySide (see
[1]):


foreach(QObject* o, QPluginLoader::staticInstances()) {
  plugin = qobject_cast<PyCustomWidgets*>(o);
  if (o)
    break;
}


it should always break after first iteration, if I correctly guess meaning of
this code. I think should be:


  if (plugin)
    break;


[1]
https://qt.gitorious.org/pyside/pyside/blobs/master/PySide/QtUiTools/glue/plugins.h

Comment 1 Hugo Parente Lima 2011-11-23 15:32:17 EET

Right.

Comment 2 Paulo Alcantara 2011-11-23 19:53:40 EET

Thanks for the bug report!

Fixed on PySide commit c3fc0784f8bc2e17f668cd0eb40f06e3cb7d008b.

Comment 3 Luciano Wolf 2011-11-29 21:28:44 EET

Released on PySide 1.0.9. Closing.