Bug 1012 – FTBFS with hardening flags enabled

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 1012 - FTBFS with hardening flags enabled

Summary:

FTBFS with hardening flags enabled

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	PySide
Version:	HEAD
Platform:	All Linux

Importance:	P3 normal
Assigned To:	Hugo Parente Lima

URL:

Depends on:
Blocks:	1037
	Show dependency tree / graph

Reported:	2011-09-23 15:03 EEST by Didier Raboud
Modified:	2011-11-29 21:28 EET (History)
CC List:	9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Didier Raboud 2011-09-23 15:03:57 EEST

Hi,

Debian has just enabled hardening flags for some packages and now PySide fails
to build:

https://buildd.debian.org/status/fetch.php?pkg=pyside&arch=amd64&ver=1.0.7-1&stamp=1316770955

Current C{,XX}FLAGS are:
-g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat
-Wformat-security -Werror=format-security

In particular, -Werror=format-security fails on qtcore_module_wrapper.cpp.

Thanks for considering a fix for this,

OdyX

Comment 1 Didier Raboud 2011-09-23 16:13:00 EEST

Just a quick note: it seems that this is not a problem on i386, where pyside
built correctly.

Comment 2 Didier Raboud 2011-09-23 16:25:16 EEST

(In reply to comment #1)
> Just a quick note: it seems that this is not a problem on i386, where pyside
> built correctly.

wrong… The build deamon had not been upgraded.

Comment 3 Didier Raboud 2011-10-31 17:48:56 EET

Hmm; I'm not sure I agree with the "Depends" of #1012 to #1037: #1012 is about
PySide and #1037 is about shiboken, so I don't see how they can be related.

Comment 4 Hugo Parente Lima 2011-10-31 19:03:42 EET

I added the dependence because you said that was using hardening flags when
compiling using python3.2 and we can compile PySide on ubuntu/debug/i386/py3.2
without those flags.

Comment 5 Hugo Parente Lima 2011-10-31 21:09:25 EET

Fixed in commit:

pyside/77a011ace9986092134aeabf6e12914ea5b85084

Comment 6 Didier Raboud 2011-11-01 10:20:15 EET

Indeed !

https://buildd.debian.org/status/logs.php?pkg=pyside&ver=1.0.8-1%2Bpy3%7Eexp1

Thanks !

Comment 7 Luciano Wolf 2011-11-29 21:28:47 EET

Released on PySide 1.0.9. Closing.