Bug 697 – Shiboken generates broken code for pointer to template arguments in virtual functions

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 697 - Shiboken generates broken code for pointer to template arguments in virtual functions

Summary:

Shiboken generates broken code for pointer to template arguments in virtual f...

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	All All

Importance:	P1 normal
Assigned To:	Marcelo Lira

URL:

Depends on:
Blocks:	698
	Show dependency tree / graph

Reported:	2011-02-22 14:22 EET by Lauro Moura
Modified:	2011-03-04 15:10 EET (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lauro Moura 2011-02-22 14:22:08 EET

If a pointer to template argument is found in a virtual function, shiboken is
generating invalid code for it both in the wrapper cpp and header signatures.

As an example, an argument QList<int>* is written as QList * (ommiting the
template wrapped type) in the method declaration and function definition.

Converter code inside the method implementation is written correctly.

This bug breaks compilation of PySide-Mobility.

Comment 1 Hugo Parente Lima 2011-02-22 15:18:53 EET

It's a P3 for PySide and a blocker for QtMobility. anyway due to the RC period
we are in only P1 bugs will be fixed on 1.0 branch to be released as 1.0.

Comment 2 Hugo Parente Lima 2011-02-22 16:24:18 EET

As Lauro said that this used to work last week before the RC1 release, it can
be considered a regression, so changing the priority to P1.

Comment 3 Marcelo Lira 2011-02-24 13:47:06 EET

This is a regression introduced in ApiExtractor/6cccd33e during an attempt to
optimize AbstractMetaType::cppSignature() method using caching to avoid
building the C++ string multiple times. The caching itself wasn't broken, the
problem was a call to cppSignature from other point before all AbstractMetaType
information was ready.

Fixed in ApiExtractor/4d377d34.

Comment 4 Hugo Parente Lima 2011-03-04 15:10:42 EET

Closing bug due to 1.0.0 release.