Bug 617 – conversion from C++ enum to PySide does not set repr() properly

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 617 - conversion from C++ enum to PySide does not set repr() properly

Summary:

conversion from C++ enum to PySide does not set repr() properly

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	All All

Importance:	P3 normal
Assigned To:	renato filho

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-01-17 15:16 EET by Farsmo
Modified:	2011-02-02 15:46 EET (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Farsmo 2011-01-17 15:16:58 EET

>>> repr(QSlider(Qt.Horizontal).orientation())
'<enum-item Orientation. (1)>'
>>> repr(Qt.Horizontal)
'<enum-item Orientation.Horizontal (1)>'

If the lookup is performed only when repr() is called there should be no impact
on performance.

Comment 1 Matti Airas 2011-01-17 15:22:54 EET

Could you give a bit more context for me: what would you expect the results to
be?

Comment 2 renato filho 2011-01-17 15:35:45 EET

I think this is duplicated of bug #611

Comment 3 Matti Airas 2011-01-17 15:41:01 EET

(In reply to comment #2)
> I think this is duplicated of bug #611

Farsmo, do you agree?

Comment 4 Farsmo 2011-01-17 17:13:51 EET

No, bug 611 is just about a missing tp_print function. It's just a matter of
defining a function that calls __repr__ and prints it. The exact content of
__repr__ does not matter in bug 611.


This bug is about the fact that __repr__ is broken for
horizontal_slider.orientation(), but not for Qt.Horizontal.

The expected results are that we should have
repr(QSlider(Qt.Horizontal).orientation()) == repr(Qt.Horizontal).

Comment 5 Matti Airas 2011-01-18 07:40:15 EET

OK, prioritizing P3.

Comment 6 renato filho 2011-01-28 20:43:39 EET

fixed on shiboken commit:

commit 9c2d358942798ef6e5ef5260d15c889e9fac95ee
Author: Renato Araujo Oliveira Filho <renato.filho@openbossa.org>
Date:   Fri Jan 28 11:57:21 2011 -0300

Comment 7 renato filho 2011-02-02 15:46:09 EET

released on beta 5