Bug 615 – QTransform.quadToQuad should have a 2-argument version

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 615 - QTransform.quadToQuad should have a 2-argument version

Summary:

QTransform.quadToQuad should have a 2-argument version

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	QtGui
Version:	HEAD
Platform:	All All

Importance:	P3 enhancement
Assigned To:	renato filho

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-01-14 13:02 EET by Farsmo
Modified:	2011-05-26 17:04 EEST (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Farsmo 2011-01-14 13:02:00 EET

Currently QTransform.quadToQuad requires, in addition to the 2 quads, passing a
dummy QTransform reference to store the result. In Python it would be more
logical to provide a 2-argument version that constructs the QTransform if
successful, and returns None on failure.

squareToQuad and quadToSquare are in the same situation.

Comment 1 Matti Airas 2011-01-17 11:04:39 EET

Thanks, Renato confirmed this indeed is a bug. Prioritizing P3.

Comment 2 Matti Airas 2011-01-17 11:21:55 EET

Correcting myself - PyQt has the same API as our current implementation, and at
the moment, beginning to tweak individual Qt classes would have only minor
benefit and would lead to other potential issues. I'm resolving this to WONTFIX
(and start a discussion on the mailing list).

Comment 3 Matti Airas 2011-01-21 05:39:11 EET

Thinking a bit more about this issue, I've changed my mind: in cases where
existing API is not changed and there's very little chance of introducing any
incompatibility, and where the existing API is really quite silly, it indeed
doesn't make sense to refrain from providing an alternative version.

I'm reopening this one, but due to the enhancement nature, I'm prioritizing the
bug P4. Tested patches are very welcome to get the implementation done sooner.
;-)

Comment 4 Hugo Parente Lima 2011-01-26 10:31:28 EET

I think we could just add another overload without the last parameter and
returning the QTransform on success and None on failure. Then we remain
backward compatible.

Comment 5 Matti Airas 2011-01-26 10:57:14 EET

(In reply to comment #4)
> I think we could just add another overload without the last parameter and
> returning the QTransform on success and None on failure. Then we remain
> backward compatible.

My thoughts exactly (and Farsmo's too, I believe).

Comment 6 Farsmo 2011-01-27 15:24:37 EET

Indeed.

Comment 7 Matti Airas 2011-03-31 11:39:11 EEST

This was deprioritized to P4 because the bug was regarded as post-1.0 material.
Now that 1.0 has been published for one month already, I'd like to see this
bumped to P3.

Comment 8 Hugo Parente Lima 2011-03-31 15:45:03 EEST

This not really a bug, it's a feature request, but P4 bugs sometimes sounds
like forgotten bugs that will never be done... bumping to P3.

P.S.: It isn't a déjà vu, it's the same message from bug 606 :-P.

Comment 9 Matti Airas 2011-03-31 16:26:32 EEST

(In reply to comment #8)
> This not really a bug, it's a feature request, but P4 bugs sometimes sounds
> like forgotten bugs that will never be done... bumping to P3.

I agree with the feature-requestness of this but as long as we haven't agreed
on whether to deal separately with the feature-bugs and error-bugs, I think
it's better to treat them equally. This could become a valid discussion point,
of course, if we start getting much more feature requests via Bugzilla.

> P.S.: It isn't a déjà vu, it's the same message from bug 606 :-P.

Indeed, and you've probably seen it more than once. ;-)

Comment 10 renato filho 2011-05-10 22:51:26 EEST

fixed on pyside commit:

commit 99c62a3a0911210c361bd84198a8ee1ea2c75fa6
Author: Renato Filho <renato.filho@openbossa.org>
Date:   Mon May 9 19:49:25 2011 -0300

Comment 11 renato filho 2011-05-26 17:04:09 EEST

PySide release 1.0.3