Bug 561 – pyside-uic generates invalid code when tab name is not translatable

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 561 - pyside-uic generates invalid code when tab name is not translatable

Summary:

pyside-uic generates invalid code when tab name is not translatable

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	pyside-tools
Version:	1.0.0 beta1
Platform:	PC Linux

Importance:	P2 normal
Assigned To:	Hugo Parente Lima

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-12-21 12:15 EET by Hereldar
Modified:	2011-02-17 19:18 EET (History)
CC List:	8 users (show)

See Also:

Attachments
Qt Designer generated file (1.01 KB, application/xml) 2010-12-21 12:15 EET, Hereldar	Details
Qt Designer generated file (27.25 KB, application/octet-stream) 2011-02-01 14:37 EET, Hereldar	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hereldar 2010-12-21 12:15:54 EET

Created attachment 200 [details]
Qt Designer generated file

Steps to Reproduce:
-------------------

    1) Generate python code:

        pyside-uic NotTranslatableTest.ui -o NotTranslatableTest.py

Actual Results:
---------------

    self.tabWidget.setTabText(
            self.tabWidget.indexOf(self.untranslatableTab),
            Untranslatable Tab)

Expected Results:
-----------------

    self.tabWidget.setTabText(
            self.tabWidget.indexOf(self.untranslatableTab),
            "Untranslatable Tab")

Platform:
---------

    Distribution:    Kubuntu 10.10
    KDE S.C.:        4.5.4
    Qt:                  4.7.0
    PySide:           1.0.0~beta1
    PySide Tools:  0.2.3

Comment 1 Matti Airas 2010-12-22 07:56:23 EET

Thanks for the bug report!

I'm prioritizing this P3 - the bug will be fixed as soon as the preceding P2/P3
bugs have been taken care of.

Comment 2 Hugo Parente Lima 2010-12-29 19:52:25 EET

Fixed in commit:

pyside-tools/89ed1f4fe0dc1bbfa98af49abfc55c944a27a0ca

Comment 3 renato filho 2011-01-06 16:19:33 EET

released on beta3

Comment 4 Hereldar 2011-02-01 14:37:28 EET

Created attachment 242 [details]
Qt Designer generated file

Excuse reopen this report but it seems that the patch used to repair created a
new problem and added quotes where it should not. In the attachment you can
check.

Steps to Reproduce:
-------------------

    1) Generate python code:

    pyside-uic LayoutTest2.ui -o LayoutTest2.py

Actual Results:
---------------

    self.comboBox.setObjectName("comboBox")
    self.comboBox.addItem("")
    self.comboBox.setItemText(0, "\"ComboBox\"")
    ...
    self.tabWidget.setTabText(self.tabWidget.indexOf(self.tab), "Tab 1")

Expected Results:
-----------------

    self.comboBox.setObjectName("comboBox")
    self.comboBox.addItem("")
    self.comboBox.setItemText(0, "ComboBox")
    ...
    self.tabWidget.setTabText(self.tabWidget.indexOf(self.tab), "Tab 1")

Platform:
---------

    Distribution: Kubuntu 11.04
    KDE S.C.:     4.6.0
    Qt:           4.7.1
    PySide:       1.0.0~beta4
    PySide Tools: 0.2.5

Comment 5 Hugo Parente Lima 2011-02-01 15:55:28 EET

This is a regression caused by the merge of pyuic4 code with our ancient fork
of pyuic4 and I didn't wrote a unit test for it, shame on me.

The current version, 0.2.6, has the same problems originally reported by you.

Comment 6 Hugo Parente Lima 2011-02-01 17:41:56 EET

I merged some changes from the newer pyqt-uic and now it's working on my
machine, however I need more time to find a way to write a proper automated
test for it.

In other words my fix will wait a bit before land onto mainline.

Matti, I suggest P2 or P3 for this bug, P2 just for the regression factor,
pyside-tools doesn't have many tests yet.

Comment 7 Matti Airas 2011-02-02 05:31:53 EET

OK, raising priority to P2 according to Hugo's recommendation.

Comment 8 Hugo Parente Lima 2011-02-04 15:52:21 EET

Fixed in commit pyside-tools/7986f216e883b8caf42532c97aea10938cb770f2

Comment 9 Hugo Parente Lima 2011-02-17 19:18:15 EET

Released in 1.0.0~rc1