Bug 513 – Hardcoded bool return type for operator overloads

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 513 - Hardcoded bool return type for operator overloads

Summary:

Hardcoded bool return type for operator overloads

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	All All

Importance:	P2 normal
Assigned To:	Hugo Parente Lima

URL:

Depends on:
Blocks:	516
	Show dependency tree / graph

Reported:	2010-12-01 10:46 EET by Bruno Araujo
Modified:	2010-12-20 11:26 EET (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Bruno Araujo 2010-12-01 10:46:22 EET

When implementing a operator overload, the type of the variable that holds the
comparison result is hardcoded to bool; this hinders binding of operators that
return anything but bool values. An example of this problem can be found in the
QGalleryProperty class, where several operators return a
QGalleryMetaDataFilter.

Comment 1 Matti Airas 2010-12-02 04:46:58 EET

Thanks for the bug report - prioritizing initially P3. As always, if you
require higher prioritization, just comment on the bug (with reasons, of course
;-)).

Comment 2 Lauro Moura 2010-12-02 08:33:34 EET

And as discussed in the mailing list[1], the metadata filters should be created
from the properties operators like in c++. 

The metadata filters can be created in two ways: using a constructor or using
this implicit way with QGalleryProperty operators. The limitation of the
constructor is that only a single property filter criteria is allowed (no
chaining).

I think this one could remain P3 or at most P2.

[1] http://lists.openbossa.org/pipermail/pyside/2010-November/001473.html

Comment 3 Matti Airas 2010-12-02 08:52:32 EET

I'll make it P2 - then we can have it fixed during the next sprint and have the
missing QGalleryProperty operators implemented in the sprint after that.

Comment 4 Hugo Parente Lima 2010-12-13 19:04:54 EET

Fixed in commit:

shiboken/66bb59f9be9f7f38af48b1c4dc1108017c06ef72

Comment 5 Hugo Parente Lima 2010-12-20 11:26:10 EET

Closign bugs after release of 1.0.0 beta2.