Bug 490 – build failure due to inconsistent naming of "_protected" methods

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 490 - build failure due to inconsistent naming of "_protected" methods

Summary:

build failure due to inconsistent naming of "_protected" methods

Status:	CLOSED DUPLICATE of bug 476

Product:	PySide
Classification:	Unclassified
Component:	Shiboken
Version:	HEAD
Platform:	PC All

Importance:	P3 critical
Assigned To:	Marcelo Lira

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-11-22 23:27 EET by Ryan Kelly
Modified:	2010-11-25 17:53 EET (History)
CC List:	8 users (show)

See Also:

Attachments
patch to cppgenerator.cpp (1.30 KB, patch) 2010-11-22 23:39 EET, Ryan Kelly	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryan Kelly 2010-11-22 23:27:51 EET

The non-protected-hack codepath in shiboken generates inconsistent names for
"_protected" wrapper methods.  The header-generator calls them
<methodName>_protected while the cpp-generator calls them
"<WrapperClassName><methodName>_protected.  This prevents building of the
pyside bindings on windows.

Relatedly, the cppgenerator incorrectly calls static protected methods as
<ClassName><methodName>_protected when is should be
<WrapperClassName><methodName>_protected.

Attached patch modifies cppgenerator to fix these issues.

Comment 1 Ryan Kelly 2010-11-22 23:39:07 EET

Created attachment 153 [details]
patch to cppgenerator.cpp

Comment 2 Matti Airas 2010-11-23 04:43:21 EET

I wonder is this a (more precise) duplicate of bug 476? Renato had just started
fixing that bug - it obviously needs to be done before our next release.

Comment 3 Matti Airas 2010-11-23 05:04:34 EET

Didn't notice Ryan's comment on bug 476 - marking this as duplicate (note that
it still has a patch attached to it).

*** This bug has been marked as a duplicate of bug 476 ***

Comment 4 Hugo Parente Lima 2010-11-25 17:53:44 EET

Released on version 1.0.0~beta1