Bug 398 – abstractmetabuilder.cpp line 2095 "or" should be ||

PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 398 - abstractmetabuilder.cpp line 2095 "or" should be ||

Summary:

abstractmetabuilder.cpp line 2095 "or" should be ||

Status:	CLOSED FIXED

Product:	PySide
Classification:	Unclassified
Component:	ApiExtractor
Version:	HEAD
Platform:	All All

Importance:	P3 normal
Assigned To:	renato filho

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-10-02 15:08 EEST by Michael H
Modified:	2010-10-13 13:49 EEST (History)
CC List:	8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael H 2010-10-02 15:08:47 EEST

Subject says it all, I believe the "or" on line 2095 in
apiextractor\abstractmetabuilder.cpp should be "||"

Comment 1 Hugo Parente Lima 2010-10-04 10:55:51 EEST

"or" is also a valid C++ keyword with the same meaning of "||" according with
C++ standard since 1998.

Anyway, we would change this line to avoid compile errors on old and non
standard compilant compilers, besides all our code is using ||, so we need to
be coerent with ourselves.

Comment 2 Hugo Parente Lima 2010-10-04 11:39:19 EEST

Fixed in commit:
apiextractor/deac4847451067e39a7ed123a81dec3db7b4da93

Comment 3 renato filho 2010-10-13 13:49:11 EEST

released on PySide 0.4.2