PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 297 - license headers missing in PySide/ directory
: license headers missing in PySide/ directory
Status: CLOSED FIXED
Product: PySide
Classification: Unclassified
Component: PySide
: HEAD
: All All
: P5 normal
Assigned To: renato filho
:
:
:
  Show dependency treegraph
 
Reported: 2010-08-15 14:02 EEST by Kalev Lember
Modified: 2010-09-10 19:21 EEST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2010-08-15 14:02:14 EEST
The source files in PySide/ directory currently lack any license headers. Could
you please add them to avoid confusion which license applies?
Comment 1 Hugo Parente Lima 2010-08-16 10:41:24 EEST
What files? xml's? or the files inside glue directories?

The files inside glue directories doesn't have license headers to avoid the
generation of ugly/illegible source codes, so if a file doesn't have a license
header, consider the /COPYING file as the license file.
Comment 2 Kalev Lember 2010-08-16 15:05:51 EEST
Yes, I was talking about the *_conversion.h files and the.cpp files in glue
directories. I'm packaging pyside for inclusion in Fedora and the question
popped up during the new package review. apiextractor, generatorrunner, and
shiboken are already in and python-pyside is being reviewed:
https://bugzilla.redhat.com/show_bug.cgi?id=623425

Fair enough; if these files end up in other generated files it would look messy
indeed. Besides /COPYING file, does the text in PySide/licensecomment.txt also
apply to the .h and .cpp files in PySide directory? Looks like it's standard
LGPLv2, as opposed to the LGPLv2 with exceptions that is used in libpyside.
Comment 3 Hugo Parente Lima 2010-08-16 16:27:41 EEST
I added Matti to the cc list, he can help with this license questions more than
me.
Comment 4 Matti Airas 2010-08-23 10:02:24 EEST
Kalev, thanks for bringing the license issue up and Hugo, thanks for giving me
a heads-up. And both, sorry for me answering so late. :-)

I guess there ought to be a separate readme/license file in PySide/ explaining
the lack of license boilerplates in the different files. Then again, the
typesystem files are arguably the most authoritative source for our bindings
(in addition to the glue code, of course), and it wouldn't be much of an issue
to include license boilerplates there.

Incidentally, the libshiboken and libpyside licenses are erroneous: they're
supposed to be plain LGPLv2.1 as well. Although not in the scope of this bug,
we'll begin fixing that too. I'll make a separate note of the issue on the
mailing list to keep all the distro packagers aware of the change.
Comment 5 Hugo Parente Lima 2010-09-09 12:06:57 EEST
Fixed in the following commits in PySide:

commit 3ef0527eaf0a9cc296c899f67ec4821f1ad1f073
Author: Hugo Parente Lima <hugo.pl@gmail.com>
Date:   Thu Sep 9 11:25:00 2010 -0300

    Fix copyright year of generated files.

    Reviewer: Luciano Wolf <luciano.wolf@openbossa.org>
              Renato Araújo <renato.filho@openbossa.org>

commit 9fbf8b778ba4565ae9ba19943adf0816317edc0d
Author: Hugo Parente Lima <hugo.pl@gmail.com>
Date:   Thu Sep 9 11:13:31 2010 -0300

    Fix project name on license boilerplates.

commit d1fa9599607c422c8db3d735338e0c2dc5a34b50
Author: Hugo Parente Lima <hugo.pl@gmail.com>
Date:   Thu Sep 9 11:03:11 2010 -0300

    Added license boilerplates to all typesystem files.

commit f9daf01879d736a8c640fd3df603a22141b2ff74
Author: Hugo Parente Lima <hugo.pl@gmail.com>
Date:   Wed Sep 8 19:57:42 2010 -0300

    Change the license boiler plates of all LGPL files removing the special
exception.

And in the following commits in shiboken:

commit dfb9d496c469570c355db3daaa3c02952813e5ad
Author: Hugo Parente Lima <hugo.pl@gmail.com>
Date:   Wed Sep 8 19:44:54 2010 -0300

    Change the license boiler plates of all LGPL files removing the special
exception.

    Reviewer: Luciano Wolf <luciano.wolf@openbossa.org>
              Renato Araújo <renato.filho@openbossa.org>