PySide Bugzilla Closed for New Bugs

PySide is now a Qt Add-on and uses the Qt Project's JIRA Bug Tracker instead of this Bugzilla instance. This Bugzilla is left for reference purposes.

Bug 1052 - PySideConfig.cmake contains an infinite loop due to missing default for SHIBOKEN_PYTHON_SUFFIX
: PySideConfig.cmake contains an infinite loop due to missing default for SHIBO...
Status: CLOSED FIXED
Product: PySide
Classification: Unclassified
Component: PySide
: 1.0.8
: All All
: P2 normal
Assigned To: Paulo Alcantara
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-09 23:58 EET by Charlie Sharpsteen
Modified: 2011-11-29 21:28 EET (History)
10 users (show)

See Also:


Attachments
Store default value for SHIBOKEN_PYTHON_SUFFIX in PySideConfig.cmake to avoid infinite loops. (1.15 KB, application/octet-stream)
2011-11-09 23:58 EET, Charlie Sharpsteen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Sharpsteen 2011-11-09 23:58:42 EET
Created attachment 445 [details]
Store default value for SHIBOKEN_PYTHON_SUFFIX in PySideConfig.cmake to avoid
infinite loops.

Most notable when installing pyside-tools:

$ cmake . -DCMAKE_INSTALL_PREFIX='/usr/local/Cellar/pyside-tools/0.2.13'
-DCMAKE_BUILD_TYPE=None -Wno-dev -DSITE_PACKAGE=lib/python2.7/site-packages 
-- The C compiler identification is GNU
-- The CXX compiler identification is GNU
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Check for working C compiler: /usr/bin/gcc-4.2
-- Check for working C compiler: /usr/bin/gcc-4.2 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Check for working CXX compiler: /usr/bin/g++-4.2
-- Check for working CXX compiler: /usr/bin/g++-4.2 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found PythonInterp: /usr/local/bin/python (found version "2.7.2")
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - not found.
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found.
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found.
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - found
-- Looking for QT_MAC_USE_COCOA
-- Looking for QT_MAC_USE_COCOA - found
-- Found Qt4: /usr/local/bin/qmake (found suitable version "4.7.4", required is
"4.5.0")
-- Using default python: 
-- Using default python: 
-- Using default python: 
-- Using default python: 
-- Using default python:

... loops until killed ...


This bug was not present in PySide 1.0.7 and I believe it may have something to
do with commit d41aff3:

 
http://qt.gitorious.org/pyside/pyside/commit/d41aff3062adbe3981f65575b544d4c9fd98689d

It looks like the source for the default python version was changed from
PYTHON_BASENAME (which appears to be depreciated and no longer holds a value
when CMake configures the template) to SHIBOKEN_PYTHON_SUFFIX but the template
for PySideConfig.cmake.in was not completely updated. A default value for
SHIBOKEN_PYTHON_SUFFIX is not stored by the template which causes a blank
string to be used. This in turn causes line 5 of the file to include its self
which throws CMake into an infinite loop.

Attached is a patch that modifies PySideConfig.cmake.in to store
@SHIBOKEN_PYTHON_SUFFIX@ so that SHIBOKEN_PYTHON_SUFFIX will never be empty.
Comment 1 Paulo Alcantara 2011-11-23 19:54:58 EET
Hi Sharpsten,

Thanks for the patch!

Fixed on PySide commit a357fbbe501a2927995a8f8c1650bfda052c3429.
Comment 2 Hugo Parente Lima 2011-11-25 21:18:09 EET
*** Bug 1035 has been marked as a duplicate of this bug. ***
Comment 3 Luciano Wolf 2011-11-29 21:28:37 EET
Released on PySide 1.0.9. Closing.